RFR: 8292269: Replace FileMapInfo::fail_continue() with Unified Logging [v8]

Matias Saavedra Silva matsaave at openjdk.org
Wed Mar 1 15:29:38 UTC 2023


> The current logging method FileMapInfo::fail_continue() method reports the reason when the CDS archive cannot be mapped and has variable behavior depending on the -Xshare mode. Logging calls are divided primarily between the "warning" and "info" channels, where the "info" channel was used to reduce the number of printed logs for expected and normal failures. 
> 
> Logging will now shift toward Unified Logging, so `fail_continue()` will be replaced with `log_info(cds)` and `log_warning(cds)`. Some genuine failures will be logged to the warning channel for better visibility. Upon actual failures, the VM will exit at MetaspaceShared::initialize_runtime_shared_and_meta_spaces() unless it is otherwise necessary. Relevant tests are updated to accommodate this change. Verified with tier1-4 tests

Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:

 - Reverted some changed tests
 - Merge branch 'master' into cdsWarning_8292269
 - Ioi patch and added error
 - Fixed a merge issue
 - Merge
 - More test fixes
 - Fixed tests
 - RequiresSharedSpaces now leads to VM exit later
 - Replaced fail_continue with log_info and log_warning
 - Merge branch 'master' into cdsWarning_8292269
 - ... and 3 more: https://git.openjdk.org/jdk/compare/07e976ac...db1fe9d5

-------------

Changes: https://git.openjdk.org/jdk/pull/12419/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12419&range=07
  Stats: 111 lines in 10 files changed: 14 ins; 44 del; 53 mod
  Patch: https://git.openjdk.org/jdk/pull/12419.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12419/head:pull/12419

PR: https://git.openjdk.org/jdk/pull/12419


More information about the hotspot-runtime-dev mailing list