RFR: JDK-8302820: Remove costs for NMTPreInit when NMT is off [v4]

[Thomas Stuefe]

On Thu, 2 Mar 2023 14:58:32 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>>> The latest version of my patch from tonight already frees the LU table nodes (see nmtPreinit.cpp 104ff). It was tested successfully tonight and in addition I ran x64 and x86 fastdebug release tests manually.
>> 
>> Ah ok, yes, I see the destructor implements option 1. I still like the idea of pursuing option 3 via a generic container if the cost of writing and maintaining it can be justified by other uses.
>
>> > The latest version of my patch from tonight already frees the LU table nodes (see nmtPreinit.cpp 104ff). It was tested successfully tonight and in addition I ran x64 and x86 fastdebug release tests manually.
>> 
>> Ah ok, yes, I see the destructor implements option 1. I still like the idea of pursuing option 3 via a generic container if the cost of writing and maintaining it can be justified by other uses.
> 
> Me too. I'll do it in a separate RFE.

> Thank you @tstuefe for addressing this. I also have come around to keeping nmtpreinit, and like this path forward. Much appreciated!

Thank you @jcking. I came around to your argument of avoiding leaks. Finding unintentional leaks is bad enough without having to deal with intentional leaks.

-------------

PR: https://git.openjdk.org/jdk/pull/12642