RFR: 8292269: Replace FileMapInfo::fail_continue() with Unified Logging [v9]

Matias Saavedra Silva matsaave at openjdk.org
Fri Mar 3 18:10:18 UTC 2023


On Wed, 1 Mar 2023 22:18:12 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> The current logging method FileMapInfo::fail_continue() method reports the reason when the CDS archive cannot be mapped and has variable behavior depending on the -Xshare mode. Logging calls are divided primarily between the "warning" and "info" channels, where the "info" channel was used to reduce the number of printed logs for expected and normal failures. 
>> 
>> Logging will now shift toward Unified Logging, so `fail_continue()` will be replaced with `log_info(cds)` and `log_warning(cds)`. Some genuine failures will be logged to the warning channel for better visibility. Upon actual failures, the VM will exit at MetaspaceShared::initialize_runtime_shared_and_meta_spaces() unless it is otherwise necessary. Relevant tests are updated to accommodate this change. Verified with tier1-4 tests
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reverted Xshare option in test

One test was failing due to an unexpected output. This PR moves the vm exit to a later stage for most cases, but in order to preserve the pre-change behavior, an early exit was added for a specific case.

-------------

PR: https://git.openjdk.org/jdk/pull/12419


More information about the hotspot-runtime-dev mailing list