RFR: 8292269: Replace FileMapInfo::fail_continue() with Unified Logging [v10]

[Calvin Cheung]

On Fri, 3 Mar 2023 18:10:14 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> The current logging method FileMapInfo::fail_continue() method reports the reason when the CDS archive cannot be mapped and has variable behavior depending on the -Xshare mode. Logging calls are divided primarily between the "warning" and "info" channels, where the "info" channel was used to reduce the number of printed logs for expected and normal failures. 
>> 
>> Logging will now shift toward Unified Logging, so `fail_continue()` will be replaced with `log_info(cds)` and `log_warning(cds)`. Some genuine failures will be logged to the warning channel for better visibility. Upon actual failures, the VM will exit at MetaspaceShared::initialize_runtime_shared_and_meta_spaces() unless it is otherwise necessary. Relevant tests are updated to accommodate this change. Verified with tier1-4 tests
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added early exit for one case

Updates look good. Just one nit.

src/hotspot/share/cds/metaspaceShared.cpp line 914:

> 912:     log_info(cds)("Core region alignment: " SIZE_FORMAT, static_mapinfo->core_region_alignment());
> 913:     dynamic_mapinfo = open_dynamic_archive();
> 914: 

Please remove this added blank line.

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12419