Integrated: 8292269: Replace FileMapInfo::fail_continue() with Unified Logging

Matias Saavedra Silva matsaave at openjdk.org
Fri Mar 3 19:03:29 UTC 2023


On Fri, 3 Feb 2023 21:02:01 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> The current logging method FileMapInfo::fail_continue() method reports the reason when the CDS archive cannot be mapped and has variable behavior depending on the -Xshare mode. Logging calls are divided primarily between the "warning" and "info" channels, where the "info" channel was used to reduce the number of printed logs for expected and normal failures. 
> 
> Logging will now shift toward Unified Logging, so `fail_continue()` will be replaced with `log_info(cds)` and `log_warning(cds)`. Some genuine failures will be logged to the warning channel for better visibility. Upon actual failures, the VM will exit at MetaspaceShared::initialize_runtime_shared_and_meta_spaces() unless it is otherwise necessary. Relevant tests are updated to accommodate this change. Verified with tier1-4 tests

This pull request has now been integrated.

Changeset: cd4b88d0
Author:    Matias Saavedra Silva <matsaave at openjdk.org>
Committer: Calvin Cheung <ccheung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/cd4b88d0d25958d3b5de2982233bc540ba5a4e3b
Stats:     113 lines in 9 files changed: 18 ins; 42 del; 53 mod

8292269: Replace FileMapInfo::fail_continue() with Unified Logging

Reviewed-by: iklam, dholmes, ccheung

-------------

PR: https://git.openjdk.org/jdk/pull/12419


More information about the hotspot-runtime-dev mailing list