RFR: 8302795: Shared archive failed on old version class with jsr bytecode [v2]

[Yumin Qi]

On Wed, 1 Mar 2023 23:31:00 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Please review this simple fix for avoid writing in to CDS archive during runtime while loading a shared old class (major_version < 50) with methods containg the jsr byte code.
>> Otherwise, JVM crashes with the following message in the hs err log:
>> `Error accessing class data sharing archive. Mapped file inaccessible during execution, possible disk/network problem.`
>> 
>> Passed tiers 1 - 4 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   make the _methods array writable during dump time for old classes with jsr bytecode

LGTM. We know after 49.0 (java 5), jsr will not be generated, so this should not be a problem for dynamic dumping too.

-------------

Marked as reviewed by minqi (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12752