RFR: JDK-8303605: Memory leaks in Metaspace gtests [v3]
Thomas Stuefe
stuefe at openjdk.org
Tue Mar 7 10:00:35 UTC 2023
On Mon, 6 Mar 2023 21:01:02 GMT, Justin King <jcking at openjdk.org> wrote:
>> Fix memory leaks identified while running Metaspace gtests.
>
> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix sign comparision mismatch
>
> Signed-off-by: Justin King <jcking at google.com>
test/hotspot/gtest/metaspace/test_virtualspacenode.cpp line 544:
> 542: delete node;
> 543: ASSERT_EQ(scomm.get(), size_t{0});
> 544: ASSERT_EQ(sres.get(), size_t{0});
While I personally like this, could you please keep cast style as in the rest of the hotspot? C-style or xxx_cast, your call.
-------------
PR: https://git.openjdk.org/jdk/pull/12865
More information about the hotspot-runtime-dev
mailing list