RFR: 8281941: Change CDS warning messages to use Unified Logging

David Holmes dholmes at openjdk.org
Thu Mar 9 05:22:10 UTC 2023


On Mon, 6 Mar 2023 21:25:38 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> As an addendum to previous commits that changed CDS logging, this replaces the remaining log messages with Unified logging. There are also old warning messages that used to be prefixed with UseSharedSpaces which have been updated along with their tests.

These changes seem fine in themselves.

There are some inconsistencies, IMO, in the choice of log-level for CDS "failures" but that would be for a separate RFE. For example I find it odd that reporting an issue trying to load the shared archive is  a warning, but the actual message the archive could not be used is only "info":

[0.001s][warning][cds] Unable to read generic CDS file map header from shared archive
[0.001s][info   ][cds] Unable to use shared archive: invalid archive


Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12890


More information about the hotspot-runtime-dev mailing list