RFR: 8303937: Corrupted heap dumps due to missing retries for os::write()

Man Cao manc at openjdk.org
Fri Mar 10 03:06:04 UTC 2023


On Fri, 10 Mar 2023 02:40:03 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> Looks good. What type of testing have you done? If you grep in the test directory for `HprofParser`, you can find the tests you should be running. You can ignore the sa tests.

Thanks for quick review. I'm running tier1 and tier2 jtreg tests now, and the pre-submit is also running tier1 tests.

I have tested with our internal application's integration test, which exposes the heap corruption and this change fixed it. However, I'm not sure how to write a jtreg test that exposes the heap corruption. We perhaps need to patch or mock write() syscall to make it return fewer bytes than the argument specifies.

-------------

PR: https://git.openjdk.org/jdk/pull/12966


More information about the hotspot-runtime-dev mailing list