RFR: 8303624: The java.lang.Thread.FieldHolder can be null for JNI attaching threads [v3]

[David Holmes]

On Thu, 9 Mar 2023 16:13:53 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update comment per @alanb
>
> Thumbs up. My only comments are nits.
> 
> I like how much cleaner the code is now.

That for the review @dcubed-ojdk !

> src/hotspot/share/classfile/javaClasses.cpp line 1715:
> 
>> 1713:          JavaThread::current()->thread_state() == _thread_in_vm,
>> 1714:          "Java Thread is not running in vm");
>> 1715:   GET_FIELDHOLDER_FIELD(java_thread, get_thread_status, JavaThreadStatus::NEW;  /* not initialized */);
> 
> I didn't expect to see a ';' after the 'NEW'. Should that be deleted?
> Should it have caused a compile error?

Well spotted. It isn't wanted but doesn't cause an error - not sure why not as it is an unreachable empty statement. Anyway it is fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/12892