RFR: 8303948: HsErrFileUtils.checkHsErrFileContent() fails to check the last pattern.

Varada M duke at openjdk.org
Fri Mar 10 09:40:11 UTC 2023


When last pattern in deque [positivePatternStack] is not matching in HsErrFile, it comes out of the loop and check whether the positivePatternStack is empty or not, which turns to be empty because the pollFirst() removes the pattern. 

This has been noticed in the TestSigInfoInHsErrFile.java where the segfault address for AIX is set as "0x0*1400" instead of "0xffffffffffffffff", which should throw the expected error but the error is neglected due to empty deque and the test is passed. 

This bug can be fixed by retrieving the pattern [peekFirst()] instead of removing the pattern [pollFirst()] and remove the pattern only if the pattern is matching [deque.remove(Pattern)] . 

JBS issue : [8303948](https://bugs.openjdk.org/browse/JDK-8303948)

-------------

Commit messages:
 - HsErrFileUtils.checkHsErrFileContent() fails to check the last pattern

Changes: https://git.openjdk.org/jdk/pull/12970/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12970&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8303948
  Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/12970.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12970/head:pull/12970

PR: https://git.openjdk.org/jdk/pull/12970


More information about the hotspot-runtime-dev mailing list