RFR: 8301684: Fix test code to not get finalizer deprecation warnings
David Holmes
dholmes at openjdk.org
Mon Mar 13 03:07:24 UTC 2023
On Mon, 13 Mar 2023 02:31:49 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/share/ClassUnloader.java line 102:
>>
>>> 100: * Here it will be used for tracking the local instance of 'CustomClassLoader'.
>>> 101: */
>>> 102: private static class CustomClassLoaderCleaner implements Runnable{
>>
>> nit: can you add a space before open { in these lines?
>> Also use // comments ?
>
> Just to be clear there should be a space before all opening braces in all the changes.
If you really need this class (not sure you do) then make it non-static so that it is always associated with its enclosing `ClassUnloader` instance, which can never be null.
-------------
PR: https://git.openjdk.org/jdk/pull/12968
More information about the hotspot-runtime-dev
mailing list