RFR: 8301684: Fix test code to not get finalizer deprecation warnings

David Holmes dholmes at openjdk.org
Mon Mar 13 03:07:27 UTC 2023


On Sat, 11 Mar 2023 07:46:36 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> To replace the finalizer use in the code, the `Cleaner` approach is used as stated in [Oracle doc on deprecated finalize() method](https://docs.oracle.com/javase/10/docs/api/java/lang/Object.html#finalize()).
>> Briefly:
>> 1.  An instance of `Cleaner` (`java.lang.ref`) is created.
>> 2. Using the `Cleaner`, an object is registered with a `Runnable` callback that is notified when the object is no longer reachable (GC'ed).
>> 3. Write code in the callback to do other cleanings.
>> 4. Or, use the `Cleanable` object which is returned from registration above and call its `clean` method to explicitly clean the object.
>> 
>> 
>> Cleaner c = new Cleaner();
>> Cleanable cleanable = c.register(an_obj, a_runnable);
>> ...
>>   //JVM notifies by calling the 
>>     a_runnable.run() {...}
>> ... 
>> // possible to explicit cleaning 
>> cleanable.clean(an_obj); 
>> 
>> ### Tests
>> local: vmTestbase/nsk/monitoring/stress/classload
>> mach5: tier 1-5
>
> test/hotspot/jtreg/vmTestbase/nsk/share/ClassUnloader.java line 114:
> 
>> 112:         @Override
>> 113:         public void run(){
>> 114:             if(class_unloader != null){
> 
> Suggestion:
> 
>             if (class_unloader != null){

BTW you don't need a null check here - this is your test code, nothing else is going to use it with null.

-------------

PR: https://git.openjdk.org/jdk/pull/12968


More information about the hotspot-runtime-dev mailing list