RFR: 8298469: Obsolete legacy parallel class loading workaround for non-parallel-capable class loaders [v2]
Coleen Phillimore
coleenp at openjdk.org
Tue Mar 14 14:04:45 UTC 2023
On Tue, 14 Mar 2023 02:48:19 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix comments.
>
> src/hotspot/share/classfile/systemDictionary.cpp line 655:
>
>> 653: // is called. A LOAD_INSTANCE placeholder isn't used for mutual exclusion.
>> 654: // case 3. traditional classloaders that rely on the classloader object lock
>> 655: // There should be no need for need for LOAD_INSTANCE for mutual exclusion,
>
> The comment on L646 needs updating: only three cases now.
missed that. removed the line as it's unnecessary
> src/hotspot/share/runtime/objectMonitor.cpp line 1375:
>
>> 1373: // reenter() enters a lock and sets recursion count
>> 1374: // complete_exit/reenter operate as a wait without waiting
>> 1375: bool ObjectMonitor::reenter(intx recursions, JavaThread* current) {
>
> AFAICS `complete_exit` is also unused now
It is still used here: // Monitor cleanup on JavaThread::exit
-------------
PR: https://git.openjdk.org/jdk/pull/12974
More information about the hotspot-runtime-dev
mailing list