RFR: 8303948: HsErrFileUtils.checkHsErrFileContent() fails to check the last pattern. [v2]
Varada M
duke at openjdk.org
Fri Mar 17 14:37:26 UTC 2023
> When last pattern in deque [positivePatternStack] is not matching in HsErrFile, it comes out of the loop and check whether the positivePatternStack is empty or not, which turns to be empty because the pollFirst() removes the pattern.
>
> This has been noticed in the TestSigInfoInHsErrFile.java where the segfault address for AIX is set as "0x0*1400" instead of "0xffffffffffffffff", which should throw the expected error but the error is neglected due to empty deque and the test is passed.
>
> JBS issue : [8303948](https://bugs.openjdk.org/browse/JDK-8303948)
Varada M has updated the pull request incrementally with one additional commit since the last revision:
8303948: HsErrFileUtils.checkHsErrFileContent() fails to check the last pattern.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/12970/files
- new: https://git.openjdk.org/jdk/pull/12970/files/a4565483..871b2e42
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=12970&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=12970&range=00-01
Stats: 5 lines in 1 file changed: 0 ins; 1 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/12970.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/12970/head:pull/12970
PR: https://git.openjdk.org/jdk/pull/12970
More information about the hotspot-runtime-dev
mailing list