RFR: 8303948: HsErrFileUtils.checkHsErrFileContent() fails to check the last pattern. [v2]

Varada M duke at openjdk.org
Fri Mar 17 14:37:27 UTC 2023


On Mon, 13 Mar 2023 06:02:03 GMT, Varada M <duke at openjdk.org> wrote:

>> This fix seems correct - thanks.
>
>> This fix seems correct - thanks.
> 
> Thanks @dholmes-ora for reviewing the changes.

> @varada1110 Ouch, thank you for finding that. Let's see how many tests now start failing :-/
> 
> Could a slightly more elegant patch not be to change the condition after the loop not from
> 
> ```
> < if (!positivePatternStack.isEmpty()) {
> > if (currentPositivePattern != null) {
> ```
> 
> ?
> 
> But I leave that up to you. Patch is also fine in its current form.

Thank you @tstuefe for the suggestion. I have made the changes please review it

-------------

PR: https://git.openjdk.org/jdk/pull/12970


More information about the hotspot-runtime-dev mailing list