RFR: 8303948: HsErrFileUtils.checkHsErrFileContent() fails to check the last pattern. [v2]

Varada M duke at openjdk.org
Mon Mar 20 06:44:56 UTC 2023


On Mon, 20 Mar 2023 02:15:09 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Varada M has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8303948: HsErrFileUtils.checkHsErrFileContent() fails to check the last pattern.
>
> test/hotspot/jtreg/runtime/ErrorHandling/HsErrFileUtils.java line 133:
> 
>> 131:                 lineNo++;
>> 132:             }
>> 133:             // check if current pattern is NULL then pattern matches else throw RuntimeException
> 
> Sorry this doesn't read very clearly to me. Suggestion:
> 
> // If the current pattern is not null then it didn't match
> 
> Thanks

Thank you @dholmes-ora for the suggestion. I have updated the comment. Please review the change.

-------------

PR: https://git.openjdk.org/jdk/pull/12970


More information about the hotspot-runtime-dev mailing list