RFR: 8304541: Modules THROW_MSG_ should return nullptr instead of JNI_FALSE

Coleen Phillimore coleenp at openjdk.org
Mon Mar 20 18:05:28 UTC 2023


On Mon, 20 Mar 2023 17:39:58 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> Cleanup in NPE code to return a proper nullptr instead of JNI_FALSE. JNI_FALSE expands to 0, which technically works as a null pointer here, but this becomes pretty confusing and strange when reading through the code

Looks good, also trivial.  I'm surprised there weren't more of these.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13105#pullrequestreview-1349137717


More information about the hotspot-runtime-dev mailing list