RFR: 8303948: HsErrFileUtils.checkHsErrFileContent() fails to check the last pattern. [v3]
David Holmes
dholmes at openjdk.org
Tue Mar 21 02:10:43 UTC 2023
On Mon, 20 Mar 2023 06:44:55 GMT, Varada M <duke at openjdk.org> wrote:
>> When last pattern in deque [positivePatternStack] is not matching in HsErrFile, it comes out of the loop and check whether the positivePatternStack is empty or not, which turns to be empty because the pollFirst() removes the pattern.
>>
>> This has been noticed in the TestSigInfoInHsErrFile.java where the segfault address for AIX is set as "0x0*1400" instead of "0xffffffffffffffff", which should throw the expected error but the error is neglected due to empty deque and the test is passed.
>>
>> JBS issue : [8303948](https://bugs.openjdk.org/browse/JDK-8303948)
>
> Varada M has updated the pull request incrementally with one additional commit since the last revision:
>
> comment
Looks good. Thanks. I will sponsor now.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/12970#pullrequestreview-1349612169
More information about the hotspot-runtime-dev
mailing list