RFR: 8303948: HsErrFileUtils.checkHsErrFileContent() fails to check the last pattern.

Varada M duke at openjdk.org
Tue Mar 21 04:54:42 UTC 2023


On Fri, 17 Mar 2023 04:47:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> When last pattern in deque [positivePatternStack] is not matching in HsErrFile, it comes out of the loop and check whether the positivePatternStack is empty or not, which turns to be empty because the pollFirst() removes the pattern. 
>> 
>> This has been noticed in the TestSigInfoInHsErrFile.java where the segfault address for AIX is set as "0x0*1400" instead of "0xffffffffffffffff", which should throw the expected error but the error is neglected due to empty deque and the test is passed. 
>> 
>> JBS issue : [8303948](https://bugs.openjdk.org/browse/JDK-8303948)
>
> Hotspot changes, including tests, require two reviewers. I'll try to get someone else to review and sponsor once done.

> @dholmes-ora The PR has been updated since the change author (@varada1110) issued the `integrate` command - the author must perform this command again.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12970#issuecomment-1477278444


More information about the hotspot-runtime-dev mailing list