RFR: 8304147: JVM crash during shutdown when dumping dynamic archive

[Calvin Cheung]

On Wed, 22 Mar 2023 05:03:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

> `DynamicArchive::prepare_for_dump_at_exit()` could be called concurrently on the two VM exit paths, leading either to assertion failures in debug builds, or a crash in product build when the actual dump occurred. The basic fix was to move the `DynamicArchive::prepare_for_dump_at_exit()` functionality into `before_exit` (java.cpp) where it can only be executed by one thread - thus avoiding the race (Phase 1).
> 
> Once that is done we can move the actual dump operation to be co-located with the `prepare_for_dump_at_exit()` (Phase 2) and then consolidate that code by refactoring it into a new `DynamicArchive::dump_at_exit()` method (Phase 3), and then removing the leftover methods that are no longer needed (Phase 4).
> 
> Each phase can be seen in distinct commits if you prefer to see the steps involved.
> 
> Testing:
>  - new ExitRace test
>  - all dynamicArchive tests
>  - tiers 1-4
> 
> Thanks.

Thanks for fixing this. I've couple of comments.

src/hotspot/share/runtime/javaThread.cpp line 2031:

> 2029:   if (this->has_pending_exception()) {
> 2030:     this->clear_pending_exception();
> 2031:   }

I think the HandleMark can be removed.
We may need to move lines 2026 - 2031 to the new `dump_at_exit` function.

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/ExitRaceTest.java line 52:

> 50:         dump(topArchiveName,
> 51:              "-Xlog:cds+dynamic=debug",
> 52:              "-XX:-CreateCoredumpOnCrash",

Why disabling core dump?

-------------

PR Review: https://git.openjdk.org/jdk/pull/13134#pullrequestreview-1353508181
PR Review Comment: https://git.openjdk.org/jdk/pull/13134#discussion_r1145430599
PR Review Comment: https://git.openjdk.org/jdk/pull/13134#discussion_r1145430945