RFR: 8304147: JVM crash during shutdown when dumping dynamic archive [v2]

[David Holmes]

On Mon, 27 Mar 2023 12:01:38 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> It is needed before calling `MetaspaceShared::link_shared_classes`. It seemed neatest to place all the "marks" together at the start of the method.
>
> The HandleMarks should be around the code that creates and uses the handles, so GC doesn't have to collect Handles that are not needed.  I don't see any Handle's escaping from link_shared_classes or any there.  If you remove the HandleMark does (or where does) the code assert?

Yes it asserts. I'll have to reproduce it in the morning to get the stack again (test directory was overwritten). In the old code it comes from the JVM_ENTRY for `before_halt`, as that has a HandleMarkCleaner.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13134#discussion_r1149799283