RFR: 8304931: vm/concepts/methods/methods001/methods00101m1/methods00101m1 failures with already pending exception

[David Holmes]

On Mon, 27 Mar 2023 19:51:27 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> The change in [JDK-8304069](https://bugs.openjdk.org/browse/JDK-8304069) resulted in an assertion failure in the case of multiple duplicate fields, methods, or interfaces. This would create unwanted pending exceptions leading to a failure later.
> 
> The method will now return following a class file parse error to avoid adding more pending errors. Verified with tiers 1-6.

Looks good.

I'd expected to see CHECK used but we know there is an exception pending so use of the macro to add a check for that is redundant, so the return works better.

Thanks. This is trivial enough to not need 24 hour wait.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13195#pullrequestreview-1359914666