Integrated: 8304147: JVM crash during shutdown when dumping dynamic archive

[David Holmes]

On Wed, 22 Mar 2023 05:03:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

> `DynamicArchive::prepare_for_dump_at_exit()` could be called concurrently on the two VM exit paths, leading either to assertion failures in debug builds, or a crash in product build when the actual dump occurred. The basic fix was to move the `DynamicArchive::prepare_for_dump_at_exit()` functionality into `before_exit` (java.cpp) where it can only be executed by one thread - thus avoiding the race (Phase 1).
> 
> Once that is done we can move the actual dump operation to be co-located with the `prepare_for_dump_at_exit()` (Phase 2) and then consolidate that code by refactoring it into a new `DynamicArchive::dump_at_exit()` method (Phase 3), and then removing the leftover methods that are no longer needed (Phase 4).
> 
> Each phase can be seen in distinct commits if you prefer to see the steps involved.
> 
> Testing:
>  - new ExitRace test
>  - all dynamicArchive tests
>  - tiers 1-4
> 
> Thanks.

This pull request has now been integrated.

Changeset: 63ce88b5
Author:    David Holmes <dholmes at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/63ce88b5fbc8e2b9be01a135156885000bc5c48d
Stats:     211 lines in 7 files changed: 156 ins; 43 del; 12 mod

8304147: JVM crash during shutdown when dumping dynamic archive

Reviewed-by: ccheung, matsaave, coleenp

-------------

PR: https://git.openjdk.org/jdk/pull/13134