RFR: 8241613: Suspicious calls to MacroAssembler::null_check(Register, offset) [v5]

[David Holmes]

On Mon, 27 Mar 2023 15:28:52 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Suggest a global place please and but not in oopDesc::klass_offset_in_bytes() because that would require oop.hpp to include os.hpp.  I couldn't find somewhere good where we wouldn't have to write a large comment to explain the context.
>
> Perhaps in `Universe::genesis()` in file universe.cpp? That is where all sorts of hand-cranked Klass-related gubbins gets set up so it seems like a sensible place to check before the create. Likewise for the array offset assert.
> 
> WDYT, Coleen/David?

That sounds okay to me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13026#discussion_r1149965645