RFR: JDK-8304884: Update Bytecodes data to be mostly compile time constants [v3]

David Holmes dholmes at openjdk.org
Tue Mar 28 05:17:33 UTC 2023


On Mon, 27 Mar 2023 14:40:02 GMT, Justin King <jcking at openjdk.org> wrote:

>> src/hotspot/share/interpreter/bytecodes.cpp line 320:
>> 
>>> 318: };
>>> 319: 
>>> 320: #define STRING_SIZE(string) StringLiteralSize::invoke(string)
>> 
>> Can't you simply use:
>> 
>> #define STRING_SIZE(string) (sizeof(string) - 1)
>> 
>> ?
>
> No, due to `nullptr` for the `wide_format`. That was my first instinct as well, then I saw `nullptr`.

Ah I see.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13179#discussion_r1150036098


More information about the hotspot-runtime-dev mailing list