RFR: 8304996: Add missing HandleMarks [v2]

[Ioi Lam]

On Wed, 29 Mar 2023 21:50:39 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> The review for [JDK-8304147](https://bugs.openjdk.org/browse/JDK-8304147) pointed out that the top-level HandleMark in dump_for_exit (added to replace the previous coverage from a HandleMarkCleaner in JVM_ENTRY) was not in the right place as no Handles were being used there. Removing that HM and fixing up the ensuing failures led to a set of fixes where HM's were missing at the place of Handle usage.
>> 
>> Testing: tiers 1-4
>> 
>> Thanks.
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Shipilev feedback - moved HMs back inside the loops.

What are the rules for using HandleMarks? In the HotSpot code, there are plenty of cases where we create a HandleMark without creating any Handles in the immediately following code. There are also plenty of cases where Handles are created in functions that do not have any HandleMarks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13215#issuecomment-1489527586