RFR: 8304996: Add missing HandleMarks [v2]
Aleksey Shipilev
shade at openjdk.org
Thu Mar 30 07:56:19 UTC 2023
On Wed, 29 Mar 2023 21:37:24 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Not sure what your issue is with "missing" - the HM's were not present where the Handles were used and hence were missing. Some cases were directly detected by removing the old HM in `dump_for_exit` but I also checked those files for other cases and added them.
When I read a synopsis "Add missing HMs", that means to me there are code paths that allocate Handles without HMs -- meaning there is a memory leak. If we just dropped an "umbrella" HM in `dump_for_exit` and only added the HMs that were needed after that removal, that just rebalances the ways we cut and slice the HMs, and that does not affect memory leaks. This distinction is important to gauge how serious the issue is, and whether it should be backported, for example. This is why I wanted to understand the meaning of "missing" here :)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13215#issuecomment-1489855066
More information about the hotspot-runtime-dev
mailing list