RFR: 8241613: Suspicious calls to MacroAssembler::null_check(Register, offset) [v7]

[Matias Saavedra Silva]

> In several places in HotSpot, the method MacroAssembler::null_check(Register, offset) is called in a way that never produces any null check in the assembly code. The method null_check(Register, offset) calls needs_explicit_null_check(offset) to determine if it must emit a null check in the assembly code or not.
> 
> needs_explicit_null_check(offset) returns true only if the offset is negative or bigger than the os page size. 
> the offset being passed is the offset of a field in the header of Java object or a Java array. In both cases, the offset is always positive and smaller than an os page size. A null_check() call with a single parameter will always produce a null check in assembly.
> 
> The cases suggested in the issue have been addressed by either removing or preserving the null_check. Verified with tier 1-3 tests.

Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:

  Comment fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13026/files
  - new: https://git.openjdk.org/jdk/pull/13026/files/5e48eb99..d62636ab

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13026&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13026&range=05-06

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/13026.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13026/head:pull/13026

PR: https://git.openjdk.org/jdk/pull/13026