RFR: 8274166: Some CDS tests ignore -Dtest.cds.runtime.options
Matias Saavedra Silva
matsaave at openjdk.org
Fri Mar 31 21:20:14 UTC 2023
The test.cds.runtime.options property is used to execute the CDS tests in a special mode. E.g., create the archived with G1 but load the archive with EpsilonGC.
Currently tests that are launched with TestCommon.runWithArchive() and CDSTestUtils.runWithArchive() can handle -Dtest.cds.runtime.options. However, some test cases, such as dynamicArchive/HelloDynamic.java, do not call the above two methods, so they ignore -Dtest.cds.runtime.options.
The fix is to move the handling of -Dtest.cds.runtime.options to TestCommon.executeAndLog, because most CDS tests use this function to launch a child JVM. Other considerations are necessary now that the option is exposed to other tests, so checks for GC and CDS are necessary.
-------------
Commit messages:
- Fixed pattern matching
- 8274166: Some CDS tests ignore -Dtest.cds.runtime.options
Changes: https://git.openjdk.org/jdk/pull/13273/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13273&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8274166
Stats: 99 lines in 3 files changed: 68 ins; 29 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/13273.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13273/head:pull/13273
PR: https://git.openjdk.org/jdk/pull/13273
More information about the hotspot-runtime-dev
mailing list