RFR: 8307067: remove broken EnableThreadSMRExtraValidityChecks option [v2]

Daniel D. Daugherty dcubed at openjdk.org
Tue May 2 20:37:21 UTC 2023


On Tue, 2 May 2023 08:04:52 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   dholmes CR - change ':' to '.'.
>
> src/hotspot/share/runtime/threadSMR.cpp line 828:
> 
>> 826:   if (java_thread != JavaThread::current()) {
>> 827:     // java_thread is not the current JavaThread so we have to verify it
>> 828:     // against the ThreadsList:
> 
> Colon at the end of the comment seems odd

Nice catch! Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13704#discussion_r1183022658


More information about the hotspot-runtime-dev mailing list