RFR: 8305082: Suppress the warning for finalize() from test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java

David Holmes dholmes at openjdk.org
Thu May 4 06:41:15 UTC 2023


On Wed, 3 May 2023 17:39:58 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> The warning is suppressed. The `finalize()` method is used intentionally as a method inherited from `Object`.
>
> Looks good!

Based on @coleenp 's comment in JBS I expected to see this test modified to use a different method from Object (i.e. hashcode() or toString() - the only other non-final methods). I don't think it is a key aspect of this test that finalize be used, and we will have to change the test again when finalize gets removed if we just suppress the warning now. As I recall the warning was only to be suppressed in tests that would be removed when finalize itself was removed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13778#issuecomment-1534162845


More information about the hotspot-runtime-dev mailing list