RFR: JDK-8305507 Add support for grace period before AbortVMOnSafepointTimeout triggers [v2]

David Holmes dholmes at openjdk.org
Mon May 8 06:55:25 UTC 2023


On Fri, 28 Apr 2023 16:37:53 GMT, Wojciech Kudla <duke at openjdk.org> wrote:

>> As described https://bugs.openjdk.org/browse/JDK-8305507 this change adds a grace period before AbortVMOnSafepointTimeout activates to allow for JVM warm-up to conclude
>
> Wojciech Kudla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Simplified getting elapsed time since VM start, added test case for -XX:AbortVMOnSafepointTimeoutDelay

test/hotspot/jtreg/runtime/Safepoint/TestAbortVMOnSafepointTimeout.java line 81:

> 79:         OutputAnalyzer output = new OutputAnalyzer(pb.start());
> 80:         output.shouldContain(TestWithDelay.PRE_STALL_TEXT);
> 81:         verifyAbortVmApplied(output);

Surely in this case there is no abort ??? Otherwise how are you actually testing the delay?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13386#discussion_r1187087440


More information about the hotspot-runtime-dev mailing list