RFR: 8306738: Select num workers for safepoint ParallelCleanupTask [v3]

Aleksey Shipilev shade at openjdk.org
Mon May 8 09:03:25 UTC 2023


On Mon, 8 May 2023 08:57:57 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Maybe "Should and can do alt-rehashing" is too strong indeed. "Need and can do rehashing" is more neutral here, and matches what code is actually checking.
>
> I see now, you are describing the negation. `!(!_needs_rehashing || !_local_table->is_safepoint_safe())`
> Confused me as the other comments described the condition.
> I think I'll rewrite the comment to be more in the same style as the ones above.

Yeah, feel free. I think the readability improvement is not in comments themselves, but in repeating the basic structure of `rehash_table()` :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13616#discussion_r1187206634


More information about the hotspot-runtime-dev mailing list