RFR: 8305082: Suppress the warning for finalize() from test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java [v2]

[David Holmes]

On Mon, 8 May 2023 17:43:55 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - 8305082: Remove finalize() from test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java
>>  - 8305082: Remove finalize() from test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java
>
> test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java line 60:
> 
>> 58:         } catch (Throwable t) {
>> 59:             throw new AssertionError(t);
>> 60:         }
> 
> I don't think you need toString() since it's public and will be found through the I interface class.  I don't know what the purpose of tryIt is. If you change the call in tryIt to clone, I think that will show that you can find clone() only if it's overridden in the class.

Yes. As discussed above only protected methods should be part of this test, so no need to add toString().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13778#discussion_r1188029536