RFR: 8307653: Adjust delay time and gc log argument in TestAbortOnVMOperationTimeout

David Holmes dholmes at openjdk.org
Tue May 9 07:36:25 UTC 2023


On Tue, 9 May 2023 05:34:06 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch increases the delay time of the test `TestAbortOnVMOperationTimeout` 
> so that it can pass on the low performance devices (such as my local riscv64 dev board).
> 
> And I adjust the gc log options to get more gc log message which is useful to
> inspect the issue [JDK-8296819](https://bugs.openjdk.org/browse/JDK-8296819).
> 
> Thanks for the review.
> 
> Best Regards,
> -- Guoxiong

Changes requested by dholmes (Reviewer).

test/hotspot/jtreg/runtime/Safepoint/TestAbortOnVMOperationTimeout.java line 58:

> 56:         for (int delay : new int[]{183423}) {
> 57:             testWith(delay, true);
> 58:         }

With only one value there is no point having the loop. Why not just replace the shorter, failing, delay with the new longer one?

-------------

PR Review: https://git.openjdk.org/jdk/pull/13878#pullrequestreview-1418049857
PR Review Comment: https://git.openjdk.org/jdk/pull/13878#discussion_r1188246856


More information about the hotspot-runtime-dev mailing list