RFR: 8305082: Suppress the warning for finalize() from test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java [v3]
David Holmes
dholmes at openjdk.org
Tue May 9 08:22:26 UTC 2023
On Tue, 9 May 2023 08:06:17 GMT, Afshin Zafari <duke at openjdk.org> wrote:
>> The warning is suppressed. The `finalize()` method is used intentionally as a method inherited from `Object`.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>
> 8305082: Remove finalize() from test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java
Changes requested by dholmes (Reviewer).
test/hotspot/jtreg/runtime/linkResolver/InterfaceObj.jasm line 2:
> 1: /*
> 2: * Copyright (c) 2020, 2023 Oracle and/or its affiliates. All rights reserved.
Need a comma after 2023
test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java line 49:
> 47: try {
> 48: Object o2 = o1.clone();
> 49: o1.clone();
Just delete this line - you've done the clone()
test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java line 62:
> 60:
> 61:
> 62: // Test with reflection without abstract public clone() and method.
Delete "and"
-------------
PR Review: https://git.openjdk.org/jdk/pull/13778#pullrequestreview-1418122793
PR Review Comment: https://git.openjdk.org/jdk/pull/13778#discussion_r1188294056
PR Review Comment: https://git.openjdk.org/jdk/pull/13778#discussion_r1188295233
PR Review Comment: https://git.openjdk.org/jdk/pull/13778#discussion_r1188295919
More information about the hotspot-runtime-dev
mailing list