RFR: 8305082: Suppress the warning for finalize() from test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java [v4]

Coleen Phillimore coleenp at openjdk.org
Tue May 9 16:07:45 UTC 2023


On Tue, 9 May 2023 10:05:40 GMT, Afshin Zafari <duke at openjdk.org> wrote:

>> The warning is suppressed. The `finalize()` method is used intentionally as a method inherited from `Object`.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8305082: Remove finalize() from test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java

Marked as reviewed by coleenp (Reviewer).

test/hotspot/jtreg/runtime/linkResolver/InterfaceObjectTest.java line 33:

> 31:  */
> 32: interface IClone extends Cloneable {
> 33:     String toString();

One more minor comment.  This can be removed and the comment above referring to toString can also be removed.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13778#pullrequestreview-1418986212
PR Review Comment: https://git.openjdk.org/jdk/pull/13778#discussion_r1188827055


More information about the hotspot-runtime-dev mailing list