RFR: 8307653: Adjust delay time and gc log argument in TestAbortOnVMOperationTimeout [v2]

Daniel D. Daugherty dcubed at openjdk.org
Wed May 10 16:34:28 UTC 2023


On Tue, 9 May 2023 09:04:14 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch increases the delay time of the test `TestAbortOnVMOperationTimeout` 
>> so that it can pass on the low performance devices (such as my local riscv64 dev board).
>> 
>> And I adjust the gc log options to get more gc log message which is useful to
>> inspect the issue [JDK-8296819](https://bugs.openjdk.org/browse/JDK-8296819).
>> 
>> Thanks for the review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unnecessary loop. Add bug id. Adjust the action time out.

> This patch increases the delay time of the test TestAbortOnVMOperationTimeout
> so that it can pass on the low performance devices (such as my local riscv64 dev board).

The proper way to address a slow piece of hardware is to use a larger timeoutFactor value.
We typically only make small changes to the default timeout value for a test. Going from
(default) `timeout=120` to `timeout=180` or `timeout=240` is fairly normal. I've even seen
some stress tests use `timeout=300`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13878#issuecomment-1542499697


More information about the hotspot-runtime-dev mailing list