RFR: 8281715: Move "base CDS archive not loaded" tests to SharedArchiveFileOption.java

Calvin Cheung ccheung at openjdk.org
Wed May 10 20:45:05 UTC 2023


On Wed, 10 May 2023 17:20:02 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> ArchiveConsistency.java is meant to check for the corruption of a CDS archive file, yet it checks for "warning: -XX:+AutoCreateSharedArchive is unsupported when base CDS archive is not loaded." These test cases should be moved to SharedArchiveFileOption.java instead. Verified with tier1-5 tests.

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/SharedArchiveFileOption.java line 243:

> 241:                     appJar, mainClass)
> 242:                     .assertNormalExit(output -> {
> 243:                         output.shouldContain("warning: -XX:+AutoCreateSharedArchive is unsupported when base CDS archive is not loaded");

I think the above could be:
    output.shouldContain("warning: " + ERROR);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13911#discussion_r1190233087


More information about the hotspot-runtime-dev mailing list