RFR: 8281715: Move "base CDS archive not loaded" tests to SharedArchiveFileOption.java

Calvin Cheung ccheung at openjdk.org
Wed May 10 20:45:06 UTC 2023


On Wed, 10 May 2023 20:17:10 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/SharedArchiveFileOption.java line 243:
>> 
>>> 241:                     appJar, mainClass)
>>> 242:                     .assertNormalExit(output -> {
>>> 243:                         output.shouldContain("warning: -XX:+AutoCreateSharedArchive is unsupported when base CDS archive is not loaded");
>> 
>> I think the above could be:
>>     output.shouldContain("warning: " + ERROR);
>
> In this case, ERROR is equal to `-XX:ArchiveClassesAtExit is....` not `-XX:+AutoCreateSharedArchive...`.

Oh, I see. Looks good then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13911#discussion_r1190360527


More information about the hotspot-runtime-dev mailing list