RFR: 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests [v2]
David Holmes
dholmes at openjdk.org
Thu May 11 03:57:44 UTC 2023
On Wed, 10 May 2023 14:40:24 GMT, Afshin Zafari <azafari at openjdk.org> wrote:
>> This PR is continuation of https://github.com/openjdk/jdk/pull/13420 which was far behind the master.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>
> 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests
I think this will have to do for now - it is hard to make small adjustments to a lot of these old tests as they just cry out to be rewritten in a cleaner way. But we can look at that in the follow up RFE.
Thanks.
test/hotspot/jtreg/vmTestbase/nsk/share/FinalizableObject.java line 28:
> 26:
> 27: /**
> 28: * This class is an simple example of finalizable object, that
s/an/a/
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13884#pullrequestreview-1421709797
PR Review Comment: https://git.openjdk.org/jdk/pull/13884#discussion_r1190605250
More information about the hotspot-runtime-dev
mailing list