RFR: 8307653: Adjust delay time and gc log argument in TestAbortOnVMOperationTimeout [v3]
David Holmes
dholmes at openjdk.org
Thu May 11 05:01:42 UTC 2023
On Thu, 11 May 2023 01:40:39 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>> Hi all,
>>
>> This patch increases the delay time of the test `TestAbortOnVMOperationTimeout`
>> so that it can pass on the low performance devices (such as my local riscv64 dev board).
>>
>> And I adjust the gc log options to get more gc log message which is useful to
>> inspect the issue [JDK-8296819](https://bugs.openjdk.org/browse/JDK-8296819).
>>
>> Thanks for the review.
>>
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove timeout option. Adjust comment. Level up the log to info.
I am okay with these changes.
I do worry that your slow dev board may expose a lot of internal timeout issues in tests - but tests should be using values modified by the timeoutFactor to compensate for slow systems where possible. Not sure how that would apply in the current case though.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13878#pullrequestreview-1421755754
More information about the hotspot-runtime-dev
mailing list