RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v11]

[Paul Hohensee]

On Tue, 9 May 2023 01:12:06 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Paul Hohensee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implement 32-bit linux Atomic::add()
>
> src/hotspot/share/services/management.cpp line 2107:
> 
>> 2105:     // when result is initialized. The iterator is created and initialized
>> 2106:     // before the call to exited_allocated_bytes to ensure we don't miss
>> 2107:     // accounting for threads that are just about to terminate.
> 
> Sorry this is only accurate if a thread updates `exited_allocated_bytes` after it removes itself from the Threads-list.

Fixed, see below.

> src/jdk.management/share/classes/com/sun/management/ThreadMXBean.java line 119:
> 
>> 117:      * @implSpec The default implementation throws UnsupportedOperationException
>> 118:      * if the Java virtual machine implementation does not support thread
>> 119:      * memory allocation measuremust, and otherwise acts as though thread
> 
> Typo: measuremust

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13814#discussion_r1192494127
PR Review Comment: https://git.openjdk.org/jdk/pull/13814#discussion_r1192494309