RFR: 8308236: Remove SystemDictionaryShared::clone_dumptime_tables()

[Calvin Cheung]

On Tue, 16 May 2023 21:05:57 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> This function was necessary because we were patching the pointers inside `SystemDictionaryShared::_dumptime_table` when dumping the CDS archive. We no longer do that since [JDK-8307567](https://bugs.openjdk.org/browse/JDK-8307567), so this function and related code can be removed.

Just one comment. Looks good otherwise.

src/hotspot/share/cds/filemap.hpp line 476:

> 474:   static void allocate_shared_path_table(TRAPS);
> 475:   static void copy_shared_path_table(ClassLoaderData* loader_data, TRAPS);
> 476:   static void clone_shared_path_table(TRAPS);

I think the `copy_shared_path_table` could be removed as well.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14020#pullrequestreview-1429535459
PR Review Comment: https://git.openjdk.org/jdk/pull/14020#discussion_r1195752725