RFR: 8263464: NMT: assert in gtest os.release_multi_mappings_vm [v4]

[Gerard Ziemski]

On Mon, 15 May 2023 17:01:50 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8263464
>>  - add support for more cases of partial regions, make test more flexible, add more tests
>>  - support partial release, add corresponding test
>>  - release memory reserved using multiple region allocations
>
> src/hotspot/share/services/virtualMemoryTracker.cpp line 563:
> 
>> 561: 
>> 562:       // Allow for the segment to be partially released
>> 563:       long offset = remove_rgn->base() - addr;
> 
> Just a fly-by (no time to look at this closer, sorry): long is incorrect for Windows (LLP64). ptrdiff_t is better but has a number of caveats. hotspot usually uses pointer_delta(), with a preceding test for order.

Thank you! Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13813#discussion_r1196829738