RFR: 8308236: Remove SystemDictionaryShared::clone_dumptime_tables() [v2]

[Calvin Cheung]

On Wed, 17 May 2023 21:23:10 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> This function was necessary because we were patching the pointers inside `SystemDictionaryShared::_dumptime_table` when dumping the CDS archive. We no longer do that since [JDK-8307567](https://bugs.openjdk.org/browse/JDK-8307567), so this function and related code can be removed.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @calvinccheung comment: remove unused copy_shared_path_table()

test/hotspot/jtreg/compiler/ciReplay/CiReplayBase.java line 159:

> 157:         removeFromCurrentDirectoryStartingWith(HS_ERR_NAME);
> 158:         remove(TEST_CORE_FILE_NAME);x
> 159:         //remove(REPLAY_FILE_NAME);

Change by accident?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14020#discussion_r1197116628