RFR: 8308407: libjvm library not reproducibly comparable between vendors [v3]

[Andrew John Hughes]

On Fri, 19 May 2023 12:58:17 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:

>> This PR fixes issue: https://bugs.openjdk.org/browse/JDK-8308407
>> 
>> It ensures that the C compilation of abstract_vm_version.o generates a minimum 64byte static C const for vm_vendor, thus ensuring for most Vendor builds the object has a 64byte string char array.
>> 
>> Since this is just a nul terminated string as before, just within a fixed 64byte location, and should a longer Vendor string be specified it will be longer, there is no change in behavior. It purely provides a fixed 64byte string array in the compiled object, which for most if not all Vendors will be sufficient.
>
> Andrew Leonard has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8308407: libjvm library not reproducibly comparable between vendors
>   
>   Signed-off-by: Andrew Leonard <anleonar at redhat.com>

Looks good to me following the revisions on the original Adoptium PR, but we should also get a review from someone who wasn't involved in that.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14058#pullrequestreview-1434541390