RFR: 8308407: libjvm library not reproducibly comparable between vendors [v3]

[Dan Heidinga]

On Fri, 19 May 2023 13:05:41 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:

>> Andrew Leonard has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   8308407: libjvm library not reproducibly comparable between vendors
>>   
>>   Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> Re-based due to upstream build break:

> > @andrew-m-leonard is 64 chars sufficient for the most common values found in the `vm_vendor` string? Some indication that this covers the major vendors would make it a clearer win.
> 
> `sizeof(VENDOR) < VENDOR_PADDING ? VENDOR_PADDING : sizeof(VENDOR)` means it will always be at least `VENDOR_PADDING` but may be longer. An earlier revision - see [adoptium/jdk#17](https://github.com/adoptium/jdk/pull/17) - did start to impose a 64 character limit, but the patch was revised to avoid this.

If  `sizeof(VENDOR)` on most distributions is >64 chars, then using 64 as a minimum provides no value.  I have no idea what the typical length of this string is and I expect most reviewers only know the value their distribution uses.  Confirming the common choices are less then 64 chars makes the reviewers lives easier as it affirms the value of the PR beyond its technical correctness.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14058#issuecomment-1554689533