RFR: 8263464: NMT: assert in gtest os.release_multi_mappings_vm [v6]

[Gerard Ziemski]

On Fri, 19 May 2023 11:53:32 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use size_t instead long
>
> src/hotspot/share/services/virtualMemoryTracker.cpp line 557:
> 
>> 555:     while (remaining > 0) {
>> 556:       ReservedMemoryRegion* remove_rgn = node_rgn->data();
>> 557:       assert(remove_rgn != nullptr, "NULL region");
> 
> Nit: `NULL` -> `null` in assert msg

Thanks, done.

> src/hotspot/share/services/virtualMemoryTracker.cpp line 577:
> 
>> 575:     return true;
>> 576:   }
>> 577:   return false;
> 
> When exactly is this reachable?

It's not, but I left it there for any code checkers not to get confused, such as parfait.

This used to be needed, not 100% if such tools got smarter, not to complain, so easier to just make sure we have it covered.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13813#discussion_r1199169784
PR Review Comment: https://git.openjdk.org/jdk/pull/13813#discussion_r1199169569